Skip to content

🌱 Add internal direct bundle install support#2252

Closed
perdasilva wants to merge 1 commit intooperator-framework:mainfrom
perdasilva:direct-bundle-install
Closed

🌱 Add internal direct bundle install support#2252
perdasilva wants to merge 1 commit intooperator-framework:mainfrom
perdasilva:direct-bundle-install

Conversation

@perdasilva
Copy link
Copy Markdown
Contributor

@perdasilva perdasilva commented Oct 7, 2025 •
edited
Loading

Description

Adds annotation driven internal bundle install for internal purposes (at least for now) to aid in the testing / validation of extension and revision status development

P.S. this is not meant for user consumption (at least not yet) and I'm avoiding making API changes to not pollute the downstream techpreview API and possibly creating confusion

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner October 7, 2025 09:15
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 7, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6f34900
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68fa4c98770a580008684085
😎 Deploy Preview https://deploy-preview-2252--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci Bot requested review from joelanford and oceanc80 October 7, 2025 09:16
@perdasilva perdasilva force-pushed the direct-bundle-install branch from 53d52c9 to 15594cc Compare October 7, 2025 09:17
@perdasilva perdasilva changed the title Direct bundle install 🌱 Direct bundle install Oct 7, 2025
@perdasilva perdasilva changed the title 🌱 Direct bundle install 🌱 Add internal direct bundle install support Oct 7, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 17.02128% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.83%. Comparing base (926d57e) to head (6f34900).
⚠️ Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
internal/operator-controller/resolve/bundle.go 0.00% 31 Missing ⚠️
cmd/operator-controller/main.go 50.00% 4 Missing and 2 partials ⚠️
internal/operator-controller/resolve/resolver.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
+ Coverage   70.41%   70.83%   +0.41%     
==========================================
  Files          90       91       +1     
  Lines        8794     7035    -1759     
==========================================
- Hits         6192     4983    -1209     
+ Misses       2189     1636     -553     
- Partials      413      416       +3
Flag Coverage Δ
e2e 45.70% <17.02%> (+0.72%) ⬆️
experimental-e2e 14.52% <0.00%> (+0.41%) ⬆️
unit 58.46% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva force-pushed the direct-bundle-install branch from 15594cc to fb36b11 Compare October 7, 2025 09:30
camilamacedo86
camilamacedo86 approved these changes Oct 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For now it seems reasonable

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

joelanford
joelanford reviewed Oct 7, 2025
View reviewed changes
Comment thread cmd/operator-controller/main.go Outdated
joelanford
joelanford reviewed Oct 7, 2025
View reviewed changes
Comment thread cmd/operator-controller/main.go Outdated
@joelanford joelanford mentioned this pull request Oct 7, 2025
Closed
4 tasks
@perdasilva perdasilva force-pushed the direct-bundle-install branch from fb36b11 to 28f3498 Compare October 8, 2025 12:51
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 8, 2025

New changes are detected. LGTM label has been removed.

@perdasilva perdasilva force-pushed the direct-bundle-install branch 3 times, most recently from e85efd0 to 2c0d54a Compare October 8, 2025 15:32
tmshort
tmshort reviewed Oct 8, 2025
View reviewed changes
Comment thread internal/operator-controller/resolve/bundle.go
pedjak
pedjak requested changes Oct 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would great to add at least some unit tests and great if we can have an e2e test demonstrating the usage.

Comment thread internal/operator-controller/resolve/bundle.go Outdated
Comment thread internal/operator-controller/resolve/bundle.go Outdated
Comment thread internal/operator-controller/resolve/bundle.go Outdated
Comment thread internal/operator-controller/resolve/bundle.go Outdated
Comment thread internal/operator-controller/resolve/bundle.go
Comment thread internal/operator-controller/resolve/bundle.go Outdated
@perdasilva
Copy link
Copy Markdown
Contributor Author

perdasilva commented Oct 10, 2025

it would great to add at least some unit tests and great if we can have an e2e test demonstrating the usage.

100% - the idea here though was to have something quick and dirty to aid us in playing around with the status stuff without having to deal with catalogs. There will definitely need to be tests of all kinds before this ever becomes user facing. Right now it shouldn't be on the critical path of other PRs. If it breaks, that's ok.

Add internal direct bundle install method
6f34900 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the direct-bundle-install branch from 2c0d54a to 6f34900 Compare October 23, 2025 15:41
@perdasilva perdasilva requested a review from pedjak October 29, 2025 14:08
@perdasilva
Copy link
Copy Markdown
Contributor Author

perdasilva commented Dec 16, 2025

closing as stale

@perdasilva perdasilva closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford joelanford left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@tmshort tmshort tmshort left review comments

@oceanc80 oceanc80 Awaiting requested review from oceanc80

@pedjak pedjak Awaiting requested review from pedjak

Assignees

@pedjak pedjak

@camilamacedo86 camilamacedo86

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@perdasilva @pedjak @joelanford @camilamacedo86 @tmshort